RFR: 8244297: Provide utility for testing for memory leaks [v5]

Florian Kirmaier fkirmaier at openjdk.java.net
Thu Oct 22 19:29:28 UTC 2020


On Fri, 2 Oct 2020 08:54:02 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8244297
>>   Fixing some wrong imports
>
> modules/javafx.base/src/test/java/test/util/memory/JMemoryBuddy.java line 299:
> 
>> 297:     }
>> 298: 
>> 299: }
> 
> Please add an empty line at the end of file.

done

> modules/javafx.base/src/test/java/test/util/memory/JMemoryBuddy.java line 95:
> 
>> 93:         int counter = stepsLeft;
>> 94: 
>> 95:         if(weakReference.get() != null) {
> 
> It requires a space after `if`, `for`, `while` statements to adhere to Java Coding guidelines.

done

-------------

PR: https://git.openjdk.java.net/jfx/pull/204


More information about the openjfx-dev mailing list