RFR: 8244297: Provide utility for testing for memory leaks [v6]

[Florian Kirmaier]

On Thu, 8 Oct 2020 06:57:31 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8244297
>>   Fixed unit-test
>
> modules/javafx.base/src/test/java/test/util/memory/JMemoryBuddy.java line 56:
> 
>> 54:     static {
>> 55:         outputFolderString = System.getProperty("jmemorybuddy.output",".");
>> 56:         overallTime = Integer.parseInt(System.getProperty("jmemorybuddy.checktime","1000"));
> 
> `sleepTime` should also be recomputed here based on `overallTime`

done

> modules/javafx.base/src/test/java/test/util/memory/JMemoryBuddy.java line 51:
> 
>> 49:     private static boolean createHeapdump = false;
>> 50:     private static int garbageAmount = 999999;
>> 51:     private static String MX_BEAN_PROXY_TYPE = "com.sun.management:type=HotSpotDiagnostic";
> 
> `MX_BEAN_PROXY_TYPE` is not constant, so it should not be all capital letters but should be named just like other variables.

done

> modules/javafx.base/src/test/java/test/util/memory/JMemoryBuddy.java line 47:
> 
>> 45: 
>> 46:     private static int steps = 10;
>> 47:     private static int overallTime = 1000;
> 
> `overallTime` can be named as `totalDuration` or `testDuration`

done

-------------

PR: https://git.openjdk.java.net/jfx/pull/204