RFR: 8244297: Provide utility for testing for memory leaks [v9]

Florian Kirmaier fkirmaier at openjdk.java.net
Sun Oct 25 13:24:45 UTC 2020


On Sat, 24 Oct 2020 18:57:27 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8244297
>>   Updated JMemoryBuddy based on codereview.
>
> Just a quick note, since I don't have time to review it today. Thanks for making the changes. I see that you added the space after `if` (except in the new method you added), but not after `for` and `while`.
> 
> I'll do more testing next week as part of my review.

Just added some more spaces!

> modules/javafx.base/src/test/java/test/util/memory/JMemoryBuddy.java line 70:
> 
>> 68: 
>> 69:         if(folder1.exists()) return folder1.getAbsolutePath();
>> 70:         if(folder2.exists()) return folder2.getAbsolutePath();
> 
> Space after `if` (I see you corrected most of them elsewhere in the code, thanks).

done

-------------

PR: https://git.openjdk.java.net/jfx/pull/204


More information about the openjfx-dev mailing list