RFR: 8255415: Nested calls to snap methods in Region give different results [v2]

Jose Pereda jpereda at openjdk.java.net
Tue Oct 27 10:43:22 UTC 2020


On Tue, 27 Oct 2020 10:18:26 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> Looks good.
>> 
>> I can confirm that this fixes the problem of `snapSizeXY(snapSizeXY(val)) != snapSizeXY(val)` and that it fixes the test case from [JDK-8199592](https://bugs.openjdk.java.net/browse/JDK-8199592) when `sizeToScene` is called (as noted above this is a fix for one of the two underlying problems).
>> 
>> I also verified that the new test will catch the bug.
>
> wondering about other places where scaled ceiling is used, f.i. snapPortion (which is package private and only used in HBox/VBox) - could they have the same problem?

@kleopatra That's a good question. 

I already saw it, but given it has private/package private access in a public class, simply trying to test it would imply creating a public access to snapPortionXX. 
I guess that is out of scope for now?

-------------

PR: https://git.openjdk.java.net/jfx/pull/336


More information about the openjfx-dev mailing list