RFR: 8255337: [TestBug] Controls unit tests - ButtonTest and ComboBoxTest - log ClassCastException [v2]

[Jeanette Winzenburg]

On Tue, 27 Oct 2020 11:35:28 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> This is a test fix.
>> 
>> Root cause:
>> - For ButtonTest - Incorrect use of MouseEventFirer - which puts Button on to the stage and shows it before firing mouse event
>> - For ComboBoxTest - adding ComboBox to a Stage, not showing the Stage but trying to show the ComboBox
>> 
>> 
>> Fix :
>> - For ButtonTest - Moved MouseEventFirer usage from test class to the 2 tests that need it
>> - For ComboBoxTest - Started using StageLoader (which adds comboBox to the stage and shows it) instead of separate Scene and Stage creation.
>> 
>> 
>> I have attached the logs captured before and after this fix to the JBS.
>
> Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review_fixes

fix looks good to me - approving, but probably will need a "real"  reviewer :)

-------------

Marked as reviewed by fastegal (Committer).

PR: https://git.openjdk.java.net/jfx/pull/337