RFR: 8252062: WebKit build fails with recent VS 2019 compiler

Arun Joseph ajoseph at openjdk.java.net
Wed Sep 2 11:26:58 UTC 2020


The WebKit build fails with recent VS 2019 compiler.

Bug: This MediaQueryEvaluator constructor takes a String parameter, but the conversion of char* to String is failing.

Fix: Use the default constructor of MediaQueryEvaluator, which also returns true for "all".

Test: Build webkit with the recent VS 2019 compiler with and without this fix. It should crash without the fix and
build with the fix.

-------------

Commit messages:
 - 8252062: WebKit build fails with recent VS 2019 compiler

Changes: https://git.openjdk.java.net/jfx/pull/294/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=294&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8252062
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jfx/pull/294.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/294/head:pull/294

PR: https://git.openjdk.java.net/jfx/pull/294


More information about the openjfx-dev mailing list