RFR: 8218973: SVG with masking is not rendering image with mask effect [v7]

Bhawesh Choudhary bchoudhary at openjdk.java.net
Fri Sep 11 06:51:06 UTC 2020


On Fri, 11 Sep 2020 00:29:53 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp line 235:
>> 
>>> 233:     } else {
>>> 234:         if (m_state.fillGradient) {
>>> 235:             setCTM(m_state.transform);
>> 
>> Why is this needed here, but not in the other places `setGradient` is called? Won't there be a similar problem with
>> `strokeRect`, `fillPath`, etc?
>
> This question is still outstanding. It seems like the call to `setCTM` is either needed before all of the `setGradient`
> calls or none of them. Can you comment?

i believe setCTM call is needed for none of them. it is a workaround i have added till i have more concrete fix. also
please note that this workaround is needed only in cases where ui scaling is more than 1.

-------------

PR: https://git.openjdk.java.net/jfx/pull/213


More information about the openjfx-dev mailing list