RFR: 8240499: Enforce whitespace checking for additional source files

Johan Vos jvos at openjdk.java.net
Mon Sep 14 08:04:04 UTC 2020


On Fri, 11 Sep 2020 13:21:29 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> The `.jcheck/conf` file is configured to check the same set of files as the old HG jcheck, namely files with the
> following extensions:
>     .java, .c, .h, .cpp, .hpp
> 
> The Skara git jcheck allows us to evolve the rules for white space checking compatibly.
> 
> This PR adds the following additional file extensions to the list of source files that need to be kept whitespace-clean:
> 
>     .cc, .css, .frag, .fxml, .g4, .gradle, .groovy, .hlsl, .jsl, .m, .metal, .mm, .stg, .vert
> 
> For ease of review, I have done the initial push as 2 commits. The first modifies the `.jcheck/conf` file and
> `tools/scripts/checkWhiteSpace` script to add the additional extensions. The second fixes the whitespace errors in the
> (39) files among those with the newly added extensions.

Tested this with before/after tests, and it works as expected.

-------------

Marked as reviewed by jvos (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/301


More information about the openjfx-dev mailing list