RFR: 8253086: Optimization of removeAll and retainAll of ObservableListWrapper

yosbits github.com+7517141+yososs at openjdk.java.net
Mon Sep 21 11:34:33 UTC 2020


On Mon, 21 Sep 2020 10:45:49 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> Since the purpose of this issue is performance tuning,
>> Rewriting with removeIf has a different purpose.
>> This is the same as the original code.
>> 
>> The iteration order is reversed because index movement does not occur during deletion. This is the same as the original
>> code.
>
> wondering why the implementation with the BitSet was choosen at all? Certainly feels like a detour, so what are the
> corner cases that I'm too blind to see?

I can't answer(, but my intuition is a pattern of lack of skill).
Officially, I don't know because the history is interrupted.

-------------

PR: https://git.openjdk.java.net/jfx/pull/305


More information about the openjfx-dev mailing list