RFR: 8251946: ObservableList.setAll does not conform to specification [v3]

Leon Linhart github.com+4029915+TheMrMilchmann at openjdk.java.net
Sat Sep 26 16:04:17 UTC 2020


On Sat, 26 Sep 2020 13:51:10 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Leon Linhart has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Reverted incorrect change and improved test coverage
>
> modules/javafx.base/src/test/java/test/javafx/collections/ObservableListTest.java line 268:
> 
>> 266:
>> 267:         r = list.setAll();
>> 268:         assertTrue(r);
> 
> Can you also test that calling `setAll` when the list is currently empty returns true? Repeating one of the earlier
> checks should work:
>         r = list.setAll("one");
>         assertTrue(r);

Sure. Added in #284 5de1a51fd3a8d744acf0b831ab4f5a0441e417d7.

-------------

PR: https://git.openjdk.java.net/jfx/pull/284


More information about the openjfx-dev mailing list