RFR: 8090110: Very bad TextArea of performance in a language environment that uses the Chinese character (KANJI)

[yosbits]

On Tue, 29 Sep 2020 09:51:06 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> Added the **Next Step** paragraph to the PR overview.
>> 
>> I think it is necessary to judge this step before fixing the resource leak. The existing code is an incomplete
>> implementation of dispose, assuming the development of MULTIPLE NODES mode.
>> @kleopatra
>> TextArea setSkin is not supported. Therefore, there is no existing application that depends on it. I can't write
>> additional tests for incomplete implementations (it always fails).
>
>> 
>> 
>> @kleopatra
>> TextArea setSkin is not supported. Therefore, there is no existing application that depends on it. I can't write
>> additional tests for incomplete implementations (it always fails).
> 
> what a fancy excuse to not write tests *chuckling
> 
> Assuming you mean [JDK-8244419](https://bugs.openjdk.java.net/browse/JDK-8244419): the way round could be to comment
> the unconditional exception throwing in dispose, write tests against your change that fail before your change and pass
> after. I'm aware that might be difficult, given that there is no cleanup whatever - but should be tried, ast least :).
> At the end, mark them with Ignore("8244419") and uncomment the exception throwing in dispose again.

I understand that some people want support for the **new features** of Skin Swiching.

-------------

PR: https://git.openjdk.java.net/jfx/pull/307