RFR: 8244297: memory leak test utility [v4]
Florian Kirmaier
fkirmaier at openjdk.java.net
Wed Sep 30 11:46:25 UTC 2020
On Fri, 25 Sep 2020 07:07:07 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
>> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
>>
>> JDK-8244297
>> Improved the JavaDoc for JMemoryBuddy
>
> Tests fail to compile, please correct the import.
> Pointed error in `ToggleButtonTest`, please check other files also when correcting this.
I've fixed the wrong imports. It would be great if Travis could check whether all systemTests are compiling.
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ToggleButtonTest.java line 45:
>
>> 43: import org.junit.Before;
>> 44: import org.junit.Test;
>> 45: import de.sandec.jmemorybuddy.JMemoryBuddy;
>
> Throws compilation error: package de.sandec.jmemorybuddy does not exist
fixed
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ToggleButtonTest.java line 161:
>
>> 159:
>> 160: @Test public void toggleGroupViaGroupAddAndRemoveClearsReference() {
>> 161: JMemoryBuddy.memoryTest(checker -> {
>
> Compilation error: cannot find symbol JMemoryBuddy
fixed
-------------
PR: https://git.openjdk.java.net/jfx/pull/204
More information about the openjfx-dev
mailing list