RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH

Kevin Rushforth kcr at openjdk.java.net
Thu Apr 1 20:10:13 UTC 2021


On Thu, 1 Apr 2021 19:38:18 GMT, Bernhard M. Wiedemann <github.com+637990+bmwiedemann at openjdk.org> wrote:

>> Ideally the latter, if feasible, so that the logic to handle `SOURCE_DATE_EPOCH` is more localized.
>
> IMHO, it would make sense to merge any clear improvement of the status-quo and debug+fix more in a later PR. "Perfect is the enemy of good."
> 
> Regarding Webkit, I know of
> https://bugs.webkit.org/show_bug.cgi?id=174540
> https://bugs.webkit.org/show_bug.cgi?id=188738
> https://build.opensuse.org/request/show/667729
> but your version is probably not *that* old.

Given the level of effort to test this, I would recommend minimizing the number of separate fixes for this enhancement. If WebKit turns out to be too big a can of worms, then it might make sense to do everything else with this fix and file a follow-on for WebKit.

> Regarding Webkit...but your version is probably not that old.

Right, we aren't nearly that old. We just updated WebKit a little over 2 months ago with recent sources (we update WebKit every six months).

-------------

PR: https://git.openjdk.java.net/jfx/pull/446


More information about the openjfx-dev mailing list