RFR: 8263807: Button types of a DialogPane are set twice, returns a wrong button

[Kevin Rushforth]

On Tue, 6 Apr 2021 06:26:46 GMT, Marius Hanl <github.com+66004280+Maran23 at openjdk.org> wrote:

>> I have one question on the fix (see below). Also, have you run all of the unit tests (not just the new one)?
>
>> 
>> 
>> I have one question on the fix (see below). Also, have you run all of the unit tests (not just the new one)?
> 
> I did run all the normal tests and ever dialog related system test. Everything passed.
> Isn't jcheck running all the tests anyway?

Thanks for the explanation. I'll finish my review shortly.

>  Isn't jcheck running all the tests anyway?

You mean GitHub Actions (jcheck doesn't build or run any tests). It would, but for two things:

1. You used the `master` branch of your repo, which is not recommended, and will cause problems for you if you ever do another pull request. See [this comment](https://github.com/openjdk/jfx/pull/432#issuecomment-801982830) added by the Skara bot.
2. You haven't enabled GitHub action on your personal fork of the `jfx` repository. See [wiki.openjdk.java.net/display/SKARA/Testing](https://wiki.openjdk.java.net/display/SKARA/Testing) for information on how to enable it.

-------------

PR: https://git.openjdk.java.net/jfx/pull/432