RFR: 8264770: BidirectionalBinding should use InvalidationListener to prevent boxing

Nir Lisker nlisker at openjdk.java.net
Tue Apr 6 14:32:12 UTC 2021


On Tue, 6 Apr 2021 12:08:39 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>>> Seems like I forgot to hit the send button on the webform. Here's the tracking number: 9069787.
>> 
>> I see it now. And thanks for providing the benchmark. That's what I was looking for.
>
> The bug is now visible here: https://bugs.openjdk.java.net/browse/JDK-8264770

The benchmark might not tell the real story. To test these sorts of performance changes you have to use JMH. There's too much relating to JIT optimizations and JVM startup to be able to rely on the current benchmark.
The theoretical point about invalidation listeners not boxing in comparison to change listeners is sound, so it won't be worse, but if we are looking for performance metrics, they need to be proper ones.

-------------

PR: https://git.openjdk.java.net/jfx/pull/454


More information about the openjfx-dev mailing list