RFR: 8263807: Button types of a DialogPane are set twice, returns a wrong button [v2]

[Ajit Ghaisas]

On Tue, 6 Apr 2021 15:43:43 GMT, Marius Hanl <github.com+66004280+Maran23 at openjdk.org> wrote:

>> When DialogPane#getButtonTypes().setAll() is called twice with the same argument(s), DialogPane#lookupButton does not return the node which is shown inside the button bar.
>> This is due DialogPane adding two list change listeners to 'buttons' (#getButtonTypes). They have the wrong order, which will result in the button bar not changing at all and the 'buttonNodes' list will recreate the dialog button(s).
>> Finally, this will make DialogPane#lookupButton returning the 'wrong' button, which is in fact not used inside the dialog button bar.
>
> Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8263807: Code review changes

Marked as reviewed by aghaisas (Reviewer).

Marked as reviewed by aghaisas (Reviewer).

-------------

PR: https://git.openjdk.java.net/jfx/pull/432