RFR: 8234920: Add SpotLight to the selection of 3D light types [v9]

Kevin Rushforth kcr at openjdk.java.net
Fri Apr 9 20:54:17 UTC 2021


On Fri, 9 Apr 2021 19:52:48 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

> The current patch uses approach 3

Right.

> and I posted a couple of replacement files in the comment above that use approach 1.

I ran it, but didn't spend any time looking at how convenient it would be from an API point of view.

> If you and Ambarish can compare these, we will have a better idea on what to do. I also think that either 1 or 2 are the best choices, so if you find approach 1 too confusing or 3 very convenient, I will merge them into approach 2.

I'm sort of leaning towards 2 (as you could probably guess from my comments above). I'd like to hear from Ambarish as well.

-------------

PR: https://git.openjdk.java.net/jfx/pull/334


More information about the openjfx-dev mailing list