RFR: 8263402: MemoryLeak: Node hardreferences it's previous Parent after csslayout and getting removed from the scene [v5]

Florian Kirmaier fkirmaier at openjdk.java.net
Sun Apr 11 15:48:11 UTC 2021


> Fixing a memory leak. 
> A node hard references its old parent after CSS layout and getting removed. 
> This shouldn't be the case, this is very counterintuitive.
> 
> The fix uses a WeakReference in CSSStyleHelper for firstStyleableAncestor.
> This should be fine because the CSS should only depend on it if it's still the real parent. 
> In that case, it doesn't get collected.

Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:

  8263402
  Minor simplification of the code, based on code review

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/424/files
  - new: https://git.openjdk.java.net/jfx/pull/424/files/e8063e30..db7e208d

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=424&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=424&range=03-04

  Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jfx/pull/424.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/424/head:pull/424

PR: https://git.openjdk.java.net/jfx/pull/424


More information about the openjfx-dev mailing list