RFR: 8185887: TableRowSkinBase fails to correctly virtualize cells in horizontal direction

[Jeanette Winzenburg]

On Mon, 31 Aug 2020 19:16:31 GMT, yosbits <github.com+7517141+yososs at openjdk.org> wrote:

> 
> 
> Since there was a problem that the cell was not updated when the window was maximized, I added a fix to TreeTableViewSkin.java.
> 

that's just the added listener to hbar properties (same as in TableViewSkin), or anything else changed? 

> Added test code (BigTreeTableViewTest) for TreeTableView to the first post.
> 
> @kleopatra
> Does the test code I added (BigTreeTableViewTest.java) also have side effects?

yeah, but why do you ask me - you could easily see for yourself :) And don't understand why you wrap the hierarchy setup in runlater (which smears a bit over the delay by filling the treeTable content at an unspecific time "later")

> 
> 
> When the startup time is measured by eye, the impression changes depending on the individual difference.

my eye is a precision instrument :) Seriously, who would do such a thingy? Obviously, it must be measured, for zeroth approximation doing so crudely by comparing currentMillis before/after showing is good enough to "see" the tendency.

> The effect of runLater affects your experience.

that's why you shouldn't do it when trying to gain insight into timing issues ;)

> 
> However, I succeeded in further improving performance by eliminating another bottleneck in TreeTableView. Of course, it also includes improvements in startup time.

cool :)

-------------

PR: https://git.openjdk.java.net/jfx/pull/125