RFR: 8089589: [ListView] ScrollBar content moves toward-backward during scrolling. [v2]
Johan Vos
jvos at openjdk.java.net
Mon Apr 12 09:41:03 UTC 2021
> This PR introduces a refactory for VirtualFlow, fixing a number of issues reported about inconsistent scrolling speed (see https://bugs.openjdk.java.net/browse/JDK-8089589)
> The problem mentioned in the JBS issue (and in related issues) is that the VirtualFlow implementation depends on cell index and cell count, instead of on pixel count. The latter is unknown when the VirtualFlow is created, and pre-calculating the size of a large set of items would be very expensive.
> Therefore, this PR uses a combination of a gradual calculation of the total size in pixels (estimatedSize) and a smoothing part that prevents the scrollback to scroll in the reverse direction as the requested change.
> This PR currently breaks a number of tests that hard-coded depend on a number of evaluations. This is inherit to the approach of this PR: if we want to estimate the total size, we need to do some additional calculations. In this PR, I try to balance between consistent behavior and performance.
Johan Vos has updated the pull request incrementally with one additional commit since the last revision:
Process reviewer comments
-------------
Changes:
- all: https://git.openjdk.java.net/jfx/pull/398/files
- new: https://git.openjdk.java.net/jfx/pull/398/files/248d0f0e..dd792176
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jfx&pr=398&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=398&range=00-01
Stats: 21 lines in 2 files changed: 0 ins; 1 del; 20 mod
Patch: https://git.openjdk.java.net/jfx/pull/398.diff
Fetch: git fetch https://git.openjdk.java.net/jfx pull/398/head:pull/398
PR: https://git.openjdk.java.net/jfx/pull/398
More information about the openjfx-dev
mailing list