RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners [v7]

Jeanette Winzenburg fastegal at openjdk.java.net
Mon Apr 12 12:01:38 UTC 2021


On Wed, 7 Apr 2021 13:11:52 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Jeanette Winzenburg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   updated doc of list/Change methods that of invalidation methods
>
> modules/javafx.controls/src/main/java/javafx/scene/control/SkinBase.java line 221:
> 
>> 219:      *  may be {@code null}
>> 220:      */
>> 221:     protected final void registerChangeListener(ObservableValue<?> property, Consumer<ObservableValue<?>> operation) {
> 
> Maybe instead of `property` use `observable` like with the invalidation methods to not confuse it with the `Property` interface.

changed as suggested - hope everybody is happy now :)

-------------

PR: https://git.openjdk.java.net/jfx/pull/409


More information about the openjfx-dev mailing list