RFR: [WIP] 8088739: [TestBug] RegionBackgroundImageUITest fail with timeout error [v2]

[Ambarish Rapte]

On Mon, 12 Apr 2021 14:33:08 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Each test in RegionBackgroundImageUITest makes several calls to `robot.getPixelColor()` on App thread. Due to this each test requires more than **60** seconds for execution.
>> 
>> Fix is to save a screen capture of Scene (on App thread) and then read pixel color from the screen capture(not on app thread). This reduces execution time of each test to less than **3** seconds.
>> Ideally with this fix(commit#1) all the tests should pass. All tests do pass on Windows and Linux but three tests fail on Mac, which used to pass without this change.
>> - RegionBackgroundImageUITest.unalignedImage
>> - RegionBackgroundFillUITest.testScenario2
>> - RegionBackgroundFillUITest.testScenario3
>> 
>> commit#2 solves the above problem. Solution is to fallback to test color again by reading it using `robot.getPixelColor()` on App thread when a test fails.
>> 
>> One test RegionBackgroundImageUITest.unalignedImage_Cover, fails only on Mac platform, before and after this fix.
>> It is reported as a new issue [JDK-8255679](https://bugs.openjdk.java.net/browse/JDK-8255679)
>> 
>> This is a test fix and affects only the tests that extend from `RegionUITestBase` test class and does not affect other tests.
>> Verified that `RegionBackgroundImageUITest` and `RegionBackgroundFillUITest` tests pass on all three platforms(except RegionBackgroundImageUITest.unalignedImage_Cover which fails on Mac).
>
> Ambarish Rapte has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge
>  - fix for tests failing on Mac
>  - ideal fix, but causes 3 test fail

Following tests fail on windows with non-integer screen scale.

**30** tests fail with **125%** scale,	
    alignedImage
    alignedImage_Contain
    alignedImage_PositionBottomRight
    alignedImage_PositionBottomRightRepeatX
    alignedImage_PositionBottomRightRepeatY
    alignedImage_PositionCenterBottom
    alignedImage_PositionCenterBottomRepeatX
    alignedImage_PositionCenterBottomRepeatY
    alignedImage_PositionCenterFiftyPercentRepeatY
    alignedImage_PositionCenterLeftRepeatY
    alignedImage_PositionCenterRepeatY
    alignedImage_PositionCenterRightRepeatY
    alignedImage_PositionCenterTopRepeatY
    alignedImage_RepeatY
    alignedImage_Round
    alignedImage_RoundSpace
    alignedImage_Space
    unalignedImage
    unalignedImage_Contain
    unalignedImage_PositionBottomRightRepeatX
    unalignedImage_PositionBottomRightRepeatY
    unalignedImage_PositionCenterBottomRepeatX
    unalignedImage_PositionCenterBottomRepeatY
    unalignedImage_PositionCenterFiftyPercentRepeatY
    unalignedImage_PositionCenterLeftRepeatY
    unalignedImage_PositionCenterRepeatY
    unalignedImage_PositionCenterRightRepeatY
    unalignedImage_PositionCenterTopRepeatY
    unalignedImage_RepeatY
    unalignedImage_Round
	
**5** tests fail with **150%** scale,
    alignedImage_PositionCenterTopRepeatX
    alignedImage_RepeatX
    unalignedImage_Cover
    unalignedImage_PositionCenterTopRepeatX
    unalignedImage_RepeatX

These tests are marked to skip execution when screen scale is non-integer.

-------------

PR: https://git.openjdk.java.net/jfx/pull/344