RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners [v2]

Jeanette Winzenburg fastegal at openjdk.java.net
Thu Apr 15 15:00:48 UTC 2021


On Thu, 15 Apr 2021 12:55:56 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/LambdaMultiplePropertyChangeListenerHandler.java line 63:
>> 
>>> 61:  */
>>> 62: public final class LambdaMultiplePropertyChangeListenerHandler {
>>> 63: // FIXME: name doesn't fit after widening to support more notification event types
>> 
>> Maybe `MultipleObservableListenersHandler`? I didn't look at the class too much.
>
> I like `MultipleObservableListenersHandler` or `LambdaMultipleObservableListenersHandler` if you want to keep `Lambda` in the name (not sure it matters much).

sorry, somehow this comment didn't reach my consciousness ;) `MultipleObservableListenersHandler` sounds fine. Would like to extract the rename to a follow-up issue, though, because it's not only used by SkinBase.

-------------

PR: https://git.openjdk.java.net/jfx/pull/409


More information about the openjfx-dev mailing list