RFR: 8264127: ListCell editing status is true, when index changes while editing [v4]

Jeanette Winzenburg fastegal at openjdk.java.net
Thu Apr 15 15:19:42 UTC 2021


On Wed, 14 Apr 2021 11:58:14 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:

>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8264127:
>   Added checks, whether the correction ammount of editStart/cancel events are triggered

curious: do you understand the dependency of update sequence (updateEditing relative to updateFocus)? 

What I see is

- `focusIndex == cellIndex` and calling updateEditing before updateFocus - all toEditing transitions are failing due to corrupting list editing state (its editingIndex seems to be changed to -1, that is effectively canceling the edit)
- `focusIndex == editingIndex` and calling updateEditing after updateFocus - all offEditing transitions are failing due to corrupting list editing state

TableCell does the latter and has no dependency on focus state - at least none I can see ;)

-------------

PR: https://git.openjdk.java.net/jfx/pull/441


More information about the openjfx-dev mailing list