RFR: 8259356: MediaPlayer's seek freezes video

[Kevin Rushforth]

On Sat, 17 Apr 2021 01:39:17 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

> This is regression (introduced) by JDK-8199527. JDK-8199527 added fix for HLS streams (unfortunately I was not able to find repro case and more details on why it was added) in gstappsink.c line 659-678 to store current caps which can be lost during seek/flush. However, this workaround broke code in gst_app_sink_render_common() line 939 which was restoring caps if they were flushed, since we set last_caps to non NULL value. Since code in gst_app_sink_render_common() did not work to propagate caps to sample our rendering code was dropping frames without caps. Fixed by setting caps on sample in HLS workaround code.

Looks good. I verified on both macOS and Windows that the seek problem is now fixed.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/464