RFR: 8196065: ListChangeListener getRemoved() returns items that were not removed. [v2]

Kevin Rushforth kcr at openjdk.java.net
Fri Apr 23 11:21:30 UTC 2021


On Fri, 23 Apr 2021 04:58:46 GMT, mstr2 <github.com+43553916+mstr2 at openjdk.org> wrote:

>> The documentation for `ObservableListBase.nextRemove` states that a single change always refers to the current state of the list, which likely means that multiple disjoint removed ranges need to be applied in order, otherwise the next change's `getFrom` doesn't refer to the correct index.
>> 
>> `SelectedItemsReadOnlyObservableList` doesn't apply removals to `itemsRefList`, which means that subsequent removals will refer to the wrong index when retrieving the removed elements. This PR fixes the calculation of the current index.
>
> mstr2 has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.

> @mstr2 force-pushed ...

In general we prefer PR authors to not do a force push once a PR is under review. In this case, there is no problem since you did it right after the review was sent, and before anyone would have had time to look at it.

-------------

PR: https://git.openjdk.java.net/jfx/pull/478


More information about the openjfx-dev mailing list