RFR: 8265469: Allow to build media and webkit for Linux-AArch64 [v2]

Johan Vos jvos at openjdk.java.net
Fri Apr 23 11:54:25 UTC 2021


On Fri, 23 Apr 2021 06:22:13 GMT, Arun Joseph <ajoseph at openjdk.org> wrote:

>> Johan Vos has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove classifier as per reviewer comment
>
> build.gradle line 3465:
> 
>> 3463:         def webkitProperties = targetProperties.webkit
>> 3464:         def classifier = (t.name != "linux" && t.name != "win") ? t.name :
>> 3465:                           IS_64 ? IS_AARCH64 ? "${t.name}-aarch64" : "${t.name}-amd64" : "${t.name}-i586"
> 
> I don't think this change is necessary as `classifier` was used for webview-deps, and it's not used anymore (removed in https://github.com/openjdk/jfx/commit/bf203ad716633e8c9f23a70448fac1ed580a7fb5). This `classifier` definition can also be removed.

that would be a good cleanup indeed.

-------------

PR: https://git.openjdk.java.net/jfx/pull/467


More information about the openjfx-dev mailing list