RFR: 8189354: ArrayIndexOutOfBoundsException when listening to selection changes on TreeTableView

Sat Apr 24 18:36:27 UTC 2021

On Sat, 24 Apr 2021 04:11:28 GMT, mstr2 <github.com+43553916+mstr2 at openjdk.org> wrote:

> This PR fixes the implementation of `ControlUtils.reducingChange`, which incorrectly computed adjacent removed indices, thus resulting in incorrect removal notifications.
> 
> Since there were no unit tests for this method, I also added a bunch of tests.
> 
> After applying this fix, I can no longer reproduce [JDK-8189354](https://bugs.openjdk.java.net/browse/JDK-8189354) and [JDK-8189228](https://bugs.openjdk.java.net/browse/JDK-8189228).

Regarding [JDK-8189228](https://bugs.openjdk.java.net/browse/JDK-8189228), if this fix also fixes that issue, then either that issue should be closed as a duplicate or else that issue should be added to this PR with `/isuse add`. I'll let @aghaisas decide which (I can see an argument to be made for either approach).

-------------

PR: https://git.openjdk.java.net/jfx/pull/480