RFR: 8189354: ArrayIndexOutOfBoundsException when listening to selection changes on TreeTableView [v2]

mstr2 github.com+43553916+mstr2 at openjdk.java.net
Sat Apr 24 20:55:52 UTC 2021


> This PR fixes the implementation of `ControlUtils.reducingChange`, which incorrectly computed adjacent removed indices, thus resulting in incorrect removal notifications.
> 
> Since there were no unit tests for this method, I also added a bunch of tests.
> 
> After applying this fix, I can no longer reproduce [JDK-8189354](https://bugs.openjdk.java.net/browse/JDK-8189354) and [JDK-8189228](https://bugs.openjdk.java.net/browse/JDK-8189228).

mstr2 has updated the pull request incrementally with two additional commits since the last revision:

 - Formatting
 - Revert change to private ctor

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/480/files
  - new: https://git.openjdk.java.net/jfx/pull/480/files/342c8249..e5ceb67d

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=480&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=480&range=00-01

  Stats: 2 lines in 2 files changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jfx/pull/480.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/480/head:pull/480

PR: https://git.openjdk.java.net/jfx/pull/480


More information about the openjfx-dev mailing list