RFR: 8189354: ArrayIndexOutOfBoundsException when listening to selection changes on TreeTableView [v3]
mstr2
github.com+43553916+mstr2 at openjdk.java.net
Sun Apr 25 15:35:58 UTC 2021
> This PR fixes the implementation of `ControlUtils.reducingChange`, which incorrectly computed adjacent removed indices, thus resulting in incorrect removal notifications.
>
> Since there were no unit tests for this method, I also added a bunch of tests.
>
> After applying this fix, I can no longer reproduce [JDK-8189354](https://bugs.openjdk.java.net/browse/JDK-8189354) and [JDK-8189228](https://bugs.openjdk.java.net/browse/JDK-8189228).
mstr2 has updated the pull request incrementally with two additional commits since the last revision:
- Revert changes to MockListObserver
- Removed ControlUtils.reducingChange
-------------
Changes:
- all: https://git.openjdk.java.net/jfx/pull/480/files
- new: https://git.openjdk.java.net/jfx/pull/480/files/e5ceb67d..50bd0200
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jfx&pr=480&range=02
- incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=480&range=01-02
Stats: 200 lines in 6 files changed: 4 ins; 193 del; 3 mod
Patch: https://git.openjdk.java.net/jfx/pull/480.diff
Fetch: git fetch https://git.openjdk.java.net/jfx pull/480/head:pull/480
PR: https://git.openjdk.java.net/jfx/pull/480
More information about the openjfx-dev
mailing list