Integrated: 8263402: MemoryLeak: Node hardreferences it's previous Parent after csslayout and getting removed from the scene
Florian Kirmaier
fkirmaier at openjdk.java.net
Tue Apr 27 11:36:36 UTC 2021
On Wed, 10 Mar 2021 22:25:32 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:
> Fixing a memory leak.
> A node hard references its old parent after CSS layout and getting removed.
> This shouldn't be the case, this is very counterintuitive.
>
> The fix uses a WeakReference in CSSStyleHelper for firstStyleableAncestor.
> This should be fine because the CSS should only depend on it if it's still the real parent.
> In that case, it doesn't get collected.
This pull request has now been integrated.
Changeset: 33bbf3f8
Author: Florian Kirmaier <fkirmaier at openjdk.org>
Committer: Nir Lisker <nlisker at openjdk.org>
URL: https://git.openjdk.java.net/jfx/commit/33bbf3f8
Stats: 109 lines in 2 files changed: 100 ins; 0 del; 9 mod
8263402: MemoryLeak: Node hardreferences it's previous Parent after csslayout and getting removed from the scene
Reviewed-by: arapte, kcr
-------------
PR: https://git.openjdk.java.net/jfx/pull/424
More information about the openjfx-dev
mailing list