Integrated: 8265206: Tree-/TableCell: editing state not updated on cell re-use

Jeanette Winzenburg fastegal at openjdk.java.net
Thu Apr 29 10:40:01 UTC 2021


On Wed, 21 Apr 2021 11:29:38 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

> Issue is missing update of Tree-/TableCell's editiable state when changing its index from editingIndex to -1. 
> 
> Seems to be a left-over from fixing cell's editing update - done in [JDK-8150525](https://bugs.openjdk.java.net/browse/JDK-8150525) - on index change for the special case of new index -1.
> 
> Fixed by cleaning out editing state in that corner case also, added tests that were failing before and passing after the fix. Note that there are also tests that passed before: the previous fix didn't add any tests, so added them here.

This pull request has now been integrated.

Changeset: ccf51e4f
Author:    Jeanette Winzenburg <fastegal at openjdk.org>
URL:       https://git.openjdk.java.net/jfx/commit/ccf51e4f4f005d28c3d8e577022b0dd91851910f
Stats:     566 lines in 6 files changed: 552 ins; 0 del; 14 mod

8265206: Tree-/TableCell: editing state not updated on cell re-use

Reviewed-by: aghaisas, jvos

-------------

PR: https://git.openjdk.java.net/jfx/pull/473


More information about the openjfx-dev mailing list