RFR: 8188026: TextFieldXXCell: NPE on calling startEdit [v3]
Marius Hanl
mhanl at openjdk.java.net
Mon Aug 16 17:12:43 UTC 2021
On Wed, 28 Jul 2021 15:12:45 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:
>> Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Reordered commit
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ListCellStartEditTest.java line 75:
>
>> 73: this.listCell = listCell;
>> 74: }
>> 75:
>
> this hit me when trying separate out the (accidentally?) single test method: all tests work on the same instance of the cell, so its state is unpredictable. Instead, parameterize on a supplier and let it provide a new cell in setup.
I see, another point where I would love we actually use JUnit5. :/
-------------
PR: https://git.openjdk.java.net/jfx/pull/569
More information about the openjfx-dev
mailing list