Integrated: 8244419: TextAreaSkin: throws UnsupportedOperation on dispose

[Jeanette Winzenburg]

On Sat, 14 Aug 2021 10:32:00 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

> The issue was a glaring contract violation of TextAreaSkin which throws a UnsupportedOperationException. The fix was to remove the throwing and cleanup on dispose which implies
> 
> in TextAreaBehavior:
> - remove the listener to focusProperty in dispose
> 
> in TextAreaSkin:
> - register all listeners to control properties via skin api
> - remove installed event filter in dispose
> - remove direct children (here only the scrollPane)
> 
> Added tests to guard the listener re-wiring (must pass before and after), and tests to expose side-effects on replacing the skin (fail before, pass after)

This pull request has now been integrated.

Changeset: 5e9f6171
Author:    Jeanette Winzenburg <fastegal at openjdk.org>
URL:       https://git.openjdk.java.net/jfx/commit/5e9f6171289ea20e2d700f2422a4eae50287dd41
Stats:     391 lines in 8 files changed: 332 ins; 37 del; 22 mod

8244419: TextAreaSkin: throws UnsupportedOperation on dispose

Reviewed-by: mhanl, arapte

-------------

PR: https://git.openjdk.java.net/jfx/pull/604