RFR: 8267472: JavaFX modules to include version information [v3]
Christian Stein
cstein at openjdk.java.net
Mon Aug 23 18:50:25 UTC 2021
On Mon, 23 Aug 2021 18:40:55 GMT, Johan Vos <jvos at openjdk.org> wrote:
>> OK, that seems reasonable, and I can't think of any downside.
>
> The only thing that makes me slightly nervous is seeing that this is needed on a number of places, leading to more code duplication (and the build.gradle is already rather large). But that is not a problem introduced with this PR, so I'm not requesting a change for this.
Yeah. At least, the four duplicated places look very similar to each other. Perhaps, those lines (adding module-related compiler args) can be extracted into a dedicated method. But that should be done, if at all, in a different task/PR.
-------------
PR: https://git.openjdk.java.net/jfx/pull/608
More information about the openjfx-dev
mailing list