RFR: 8276313: ScrollPane scroll delta incorrectly depends on content height [v2]

Michael Strauß mstrauss at openjdk.java.net
Wed Dec 1 14:03:32 UTC 2021


On Wed, 1 Dec 2021 09:45:40 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Handle division by zero
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/ScrollPaneSkin.java line 896:
> 
>> 894:                 double vPixelValue;
>> 895:                 if (nodeHeight > 0.0) {
>> 896:                     vPixelValue = vRange / (nodeHeight - contentHeight);
> 
> This may result in divide by 0.

Good catch! I've also fixed a few similar issues in other places.

-------------

PR: https://git.openjdk.java.net/jfx/pull/660


More information about the openjfx-dev mailing list