RFR: 8272118: ListViewSkin et al: must not cancel edit on scrolling

[Kevin Rushforth]

On Thu, 25 Nov 2021 15:46:01 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

> Issue was that mouse pressed on the scrollbars of all virtualized controls cancelled the edit. That's inconsistent with other scroll triggers (mouseWheel, programmatic). Fixed by removing the cancel.
> 
> Added tests that failed/passed before/after the fix. Also added tests that passed both before/after to guarantee that required functionality of the mouse pressed (= requesting focus on the control if needed) is still working.

Looks good. Thanks for adding all the tests!

modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/EditAndScrollTest.java line 408:

> 406: 
> 407: 
> 408: //----------------- Utility methods (TODO: move into infrastructure)

Can you file a follow-up issue for this?

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/682