RFR: 8272118: ListViewSkin et al: must not cancel edit on scrolling

Jeanette Winzenburg fastegal at openjdk.java.net
Thu Dec 2 11:06:22 UTC 2021


On Thu, 2 Dec 2021 00:18:37 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Issue was that mouse pressed on the scrollbars of all virtualized controls cancelled the edit. That's inconsistent with other scroll triggers (mouseWheel, programmatic). Fixed by removing the cancel.
>> 
>> Added tests that failed/passed before/after the fix. Also added tests that passed both before/after to guarantee that required functionality of the mouse pressed (= requesting focus on the control if needed) is still working.
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/EditAndScrollTest.java line 408:
> 
>> 406: 
>> 407: 
>> 408: //----------------- Utility methods (TODO: move into infrastructure)
> 
> Can you file a follow-up issue for this?

yeah, sure - was undecided whether to do it here or later (locally, there are more that will be added for fixing related issues) - [JDK-8278134](https://bugs.openjdk.java.net/browse/JDK-8278134)

-------------

PR: https://git.openjdk.java.net/jfx/pull/682


More information about the openjfx-dev mailing list