Integrated: 8272118: ListViewSkin et al: must not cancel edit on scrolling

Jeanette Winzenburg fastegal at openjdk.java.net
Thu Dec 2 11:06:23 UTC 2021


On Thu, 25 Nov 2021 15:46:01 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

> Issue was that mouse pressed on the scrollbars of all virtualized controls cancelled the edit. That's inconsistent with other scroll triggers (mouseWheel, programmatic). Fixed by removing the cancel.
> 
> Added tests that failed/passed before/after the fix. Also added tests that passed both before/after to guarantee that required functionality of the mouse pressed (= requesting focus on the control if needed) is still working.

This pull request has now been integrated.

Changeset: aa045c5e
Author:    Jeanette Winzenburg <fastegal at openjdk.org>
URL:       https://git.openjdk.java.net/jfx/commit/aa045c5e60f9566748b55d745d162d0c94ba5e59
Stats:     594 lines in 6 files changed: 566 ins; 28 del; 0 mod

8272118: ListViewSkin et al: must not cancel edit on scrolling

Reviewed-by: aghaisas, kcr

-------------

PR: https://git.openjdk.java.net/jfx/pull/682


More information about the openjfx-dev mailing list