RFR: 8276553: ListView scrollTo() is broken after fix for JDK-8089589 [v2]

Johan Vos jvos at openjdk.java.net
Fri Dec 3 11:25:50 UTC 2021


On Fri, 3 Dec 2021 10:24:52 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> Johan Vos has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move functionality in the setCellCount() to the invalidated block.
>>   Some hard numbers used in tests (counters for evaluations) were changed because of this.
>>   Instead of relying on hard values, I modified the failing was into relative ones.
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java line 860:
> 
>> 858:             int cellCount = get();
>> 859:             resetSizeEstimates();
>> 860:             recalculateAndImproveEstimatedSize(2);
> 
> We can use recalculateEstimatedSize() instead of this method.
> The effect is the same improvement with a size of 2.

True, good suggestion. I pushed that change.

-------------

PR: https://git.openjdk.java.net/jfx/pull/683


More information about the openjfx-dev mailing list