RFR: 8276553: ListView scrollTo() is broken after fix for JDK-8089589 [v3]
Johan Vos
jvos at openjdk.java.net
Fri Dec 3 20:46:48 UTC 2021
On Fri, 3 Dec 2021 18:47:24 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
> The fix and new test looks fine. I added one comment/question regarding the existing tests that check a count, but I'm OK with either answer.
The suggestion to test for positive values of the counters is a good idea. The lower this counter the better, but if the counter is 0, this means there has been no evaluation of updateItem. This should cause other tests to fail, but it helps if it would trigger a failure in this test as well.
I added these asserts on the places where previously the expected value was not 0.
-------------
PR: https://git.openjdk.java.net/jfx/pull/683
More information about the openjfx-dev
mailing list