RFR: 8278595: Provide more information when a pipeline can't be used
Kevin Rushforth
kcr at openjdk.java.net
Mon Dec 13 13:07:13 UTC 2021
On Mon, 13 Dec 2021 11:00:02 GMT, Johan Vos <jvos at openjdk.org> wrote:
> This PR provides at least some basic information when a pipeline can't be used.
> There are a number of reasons why a candidate pipeline can't be used, and this PR makes it clear at which point the pipeline fails.
>
> The changes are only applied in case `prism.verbose` is already set to `true`, so there is no unwanted logging.
Looks fine. I left one minor comment about an extra blank line. You can fix it or not. I'll re-approve if you do.
modules/javafx.graphics/src/main/java/com/sun/prism/es2/ES2Pipeline.java line 75:
> 73: creator = Thread.currentThread();
> 74:
> 75:
Minor: extra blank line not needed.
-------------
Marked as reviewed by kcr (Lead).
PR: https://git.openjdk.java.net/jfx/pull/693
More information about the openjfx-dev
mailing list