RFR: 8278595: Provide more information when a pipeline can't be used [v2]
Kevin Rushforth
kcr at openjdk.java.net
Mon Dec 13 16:46:11 UTC 2021
On Mon, 13 Dec 2021 16:31:46 GMT, Johan Vos <jvos at openjdk.org> wrote:
>> This PR provides at least some basic information when a pipeline can't be used.
>> There are a number of reasons why a candidate pipeline can't be used, and this PR makes it clear at which point the pipeline fails.
>>
>> The changes are only applied in case `prism.verbose` is already set to `true`, so there is no unwanted logging.
>
> Johan Vos has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix (minor) formatting issues.
Marked as reviewed by kcr (Lead).
modules/javafx.graphics/src/main/java/com/sun/prism/GraphicsPipeline.java line 239:
> 237: if (PrismSettings.verbose) {
> 238: System.err.println("GraphicsPipeline.createPipeline: error" +
> 239: " initializing pipeline "+ className);
Since you fixed one minor preexisting formatting issue with a missing space before the `+`, do you want to fix the one on the next line (239), too?
-------------
PR: https://git.openjdk.java.net/jfx/pull/693
More information about the openjfx-dev
mailing list