RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v6]
Johan Vos
jvos at openjdk.java.net
Fri Dec 17 13:09:23 UTC 2021
On Fri, 17 Dec 2021 12:56:40 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Kevin Rushforth has updated the pull request incrementally with one additional commit since the last revision:
>>
>> More review comments
>>
>> 1. Renamed "Contributing to...codebase" section to "Coding style and testing guidelines", and switched that section with the "New features section"
>> 2. Updated recommend JDK
>> 3. Added forward reference for Draft and WIP PRs
>
> CONTRIBUTING.md line 176:
>
>> 174:
>> 175: Adding a new feature to OpenJFX requires us to consider what it means to support that API forever; we take compatibility seriously.
>> 176: The main idea is to think in terms of "stewardship" when evolving the JavaFX API. This will require significant effort on your part.
>
> @johanvos to address your point about maintenance, what do you think about adding a sentence here? Something like:
>
> This will require significant effort on your part. __It begins before you submit a pull request for review, and continues after the new feature is integrated.__
>
> We can follow this up with more detail in the code review guidelines.
That's a good sentence. It clearly and concisely tells what it is expected.
-------------
PR: https://git.openjdk.java.net/jfx/pull/303
More information about the openjfx-dev
mailing list