RFR: 8273096: Add support for H.265/HEVC to JavaFX Media [v2]

Kevin Rushforth kcr at openjdk.java.net
Fri Dec 17 17:26:26 UTC 2021


On Sat, 11 Dec 2021 03:20:54 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8273096: Add support for H.265/HEVC to JavaFX Media [v3]
>
> modules/javafx.media/src/main/native/gstreamer/plugins/mfwrapper/mfwrapper.cpp line 559:
> 
>> 557:             hr = MFSetAttributeRatio(pInputType, MF_MT_PIXEL_ASPECT_RATIO, unNumerator, unDenominator);
>> 558:         else
>> 559:             hr = S_OK;
> 
> I fixed get/set MF_MT_PIXEL_ASPECT_RATIO and MF_MT_DEFAULT_STRIDE. We should only set it if we get it and it is ok if aspect ration or stride is not available. In way it is currently written we will overwrite value of hr if it is failed and never exit a loop as well.

ok

-------------

PR: https://git.openjdk.java.net/jfx/pull/649


More information about the openjfx-dev mailing list