RFR: 8234921: Add DirectionalLight to the selection of 3D light types [v3]
Nir Lisker
nlisker at openjdk.java.net
Mon Dec 20 13:13:13 UTC 2021
On Mon, 20 Dec 2021 12:57:51 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixes for review comments
>
> tests/performance/3DLighting/attenuation/Environment.java line 87:
>
>> 85:
>> 86: directionalLight1.setDirection(new Point3D(-LIGHT_X_DIST, 0, LIGHT_Z_DIST));
>> 87: directionalLight2.setDirection(new Point3D(LIGHT_X_DIST, 0, LIGHT_Z_DIST));
>
> You need to add an import for `Point3D`.
Weird that the IDE didn't warn. It seems like it did not identify the file as part of the source code.
-------------
PR: https://git.openjdk.java.net/jfx/pull/548
More information about the openjfx-dev
mailing list