RFR: 8197991: Selecting many items in a TableView is very slow [v4]
Kevin Rushforth
kcr at openjdk.java.net
Wed Dec 22 13:52:23 UTC 2021
On Tue, 21 Dec 2021 12:21:57 GMT, Abhinay Agarwal <duke at openjdk.java.net> wrote:
>> This work improves the performance of `MultipleSelectionModel` over large data sets by caching some values and avoiding unnecessary calls to `SelectedIndicesList#size`. It further improves the performance by reducing the number of iterations required to find the index of an element in the BitSet.
>>
>> The work is based on [an abandoned patch](https://github.com/openjdk/jfx/pull/127) submitted by @yososs
>>
>> There are currently 2 manual tests for this fix.
>
> Abhinay Agarwal has updated the pull request incrementally with two additional commits since the last revision:
>
> - Add space around operator and string
> - Add license header and add space around operators
I think this is very close to being ready to go in. I left one more inline comment about the invalidation of `size`. There is also a pending minor code formatting comment.
-------------
PR: https://git.openjdk.java.net/jfx/pull/673
More information about the openjfx-dev
mailing list