RFR: 8260163: IrresponsiveScriptTest.testInfiniteLoopInScript unit test fails on Windows

[Kevin Rushforth]

On Mon, 1 Feb 2021 03:31:10 GMT, Arun Joseph <ajoseph at openjdk.org> wrote:

> Windows uses `WorkQueueGeneric` instead of `WorkQueueWin` from WebKit 610.2 onwards. In `WorkQueueWin`, `WorkQueue::dispatchAfter()` had a 20 ms `slopAdjustment` as the timer (called from `::SetTimer`) sometimes fire a few ms early. The same is not present in `WorkQueueGeneric` and needs to be added.
> 
> Also removing `WorkQueueWin` as it's removed for WebKit as well.

The fix and the test look good with one question and one doc comment.

modules/javafx.web/src/main/native/Source/WTF/wtf/generic/WorkQueueGeneric.cpp line 78:

> 76:     // Adding the slop adjustment from wtf/win/WorkQueueWin.cpp
> 77:     const Seconds slopAdjustment { 20_ms };
> 78:     delay += slopAdjustment;

Can you replace the above comment with the actual comment from the (now-deleted) `WorkQueueWin.cpp` file? Also, I see that the original fix only added the `slopAdjustment` if `delay` was non-zero. Should that be preserved?

-------------

PR: https://git.openjdk.java.net/jfx/pull/391