RFR: 8260163: IrresponsiveScriptTest.testInfiniteLoopInScript unit test fails on Windows [v2]

Arun Joseph ajoseph at openjdk.java.net
Mon Feb 1 17:36:44 UTC 2021


On Mon, 1 Feb 2021 16:55:50 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Arun Joseph has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update comment
>
> modules/javafx.web/src/main/native/Source/WTF/wtf/generic/WorkQueueGeneric.cpp line 85:
> 
>> 83:     // so far.
>> 84:     const Seconds slopAdjustment { 20_ms };
>> 85:     if (delay)
> 
> Since `delay` is an object of type `Seconds`, should this be `if (delay.milliseconds())`? Otherwise, won't it just check whether the object is non-null?

In [Seconds.h](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WTF/wtf/Seconds.h), there's an `operator bool()` which checks the m_value.

-------------

PR: https://git.openjdk.java.net/jfx/pull/391


More information about the openjfx-dev mailing list