RFR: 8255572: Axis does not compute preferred height properly when autoRanging is off [v5]

Jonathan Vusich github.com+31666175+jonathanvusich at openjdk.java.net
Mon Feb 1 21:02:52 UTC 2021


> As noted in the corresponding JBS issue, `Axis` does not properly compute its preferred height when `autoRanging` is turned off. The simplest fix seems to be changing `CategoryAxis` so that `tickLabelRotation` is set to 90 degrees if there is not enough room for the category labels to layout horizontally. This fixes the fact that the axis labels are truncated and also ensures that the chart does not leave unused space from the layout calculations. `CategoryAxis` is already setting the `categorySpacing` property when `autoRanging` is off, so this seems to be an appropriate fix.

Jonathan Vusich has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:

 - Remove unused import
 - Unrotate labels if there is enough space for them
 - Added copyright header
 - Added fix and test

-------------

Changes: https://git.openjdk.java.net/jfx/pull/342/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=342&range=04
  Stats: 126 lines in 2 files changed: 126 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jfx/pull/342.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/342/head:pull/342

PR: https://git.openjdk.java.net/jfx/pull/342


More information about the openjfx-dev mailing list